lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter
From
From: Joe Perches <joe@perches.com>
Date: Wed, 09 Sep 2015 17:40:56 -0700

> The code around the allocation and loops are a bit obfuscated.
>
> Neaten it by using:
>
> o kcalloc with decimal count and sizeof(u32)
> o Decimal loop indexing and i++ not i += 4
> o A promiscuous block using a similar style
> to the multicast block
> o Remove unnecessary variables
>
> Signed-off-by: Joe Perches <joe@perches.com>

Applied.


\
 
 \ /
  Last update: 2015-09-15 22:01    [W:0.040 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site