Messages in this thread | | | Date | Tue, 15 Sep 2015 12:49:32 -0700 (PDT) | Subject | Re: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Wed, 09 Sep 2015 17:40:56 -0700
> The code around the allocation and loops are a bit obfuscated. > > Neaten it by using: > > o kcalloc with decimal count and sizeof(u32) > o Decimal loop indexing and i++ not i += 4 > o A promiscuous block using a similar style > to the multicast block > o Remove unnecessary variables > > Signed-off-by: Joe Perches <joe@perches.com>
Applied.
| |