lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH v1] mm: migrate: hugetlb: putback destination hugepage to active list
    Date
    my bad, this patch is totally unrelated to the thread the previous email
    replied to. I just mishandled my script wrapping git-send-email, sorry.

    But just resending patch seems to be noisy, so I want this to be reviewed
    on this email.
    If it's inconvenient or uncommon way of submission, please let me know and
    I'll resend in a new thread.

    Thanks,
    Naoya Horiguchi

    On Wed, Sep 16, 2015 at 12:21:04AM +0000, Naoya Horiguchi wrote:
    > Since commit bcc54222309c ("mm: hugetlb: introduce page_huge_active")
    > each hugetlb page maintains its active flag to avoid a race condition between
    > multiple calls of isolate_huge_page(), but current kernel doesn't set the flag
    > on a hugepage allocated by migration because the proper putback routine isn't
    > called. This means that users could still encounter the race referred to by
    > bcc54222309c in this special case, so this patch fixes it.
    >
    > Fixes: bcc54222309c ("mm: hugetlb: introduce page_huge_active")
    > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
    > Cc: <stable@vger.kernel.org> #4.1
    > ---
    > mm/migrate.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git v4.3-rc1/mm/migrate.c v4.3-rc1_patched/mm/migrate.c
    > index c3cb566af3e2..7452a00bbb50 100644
    > --- v4.3-rc1/mm/migrate.c
    > +++ v4.3-rc1_patched/mm/migrate.c
    > @@ -1075,7 +1075,7 @@ static int unmap_and_move_huge_page(new_page_t get_new_page,
    > if (rc != MIGRATEPAGE_SUCCESS && put_new_page)
    > put_new_page(new_hpage, private);
    > else
    > - put_page(new_hpage);
    > + putback_active_hugepage(new_hpage);
    >
    > if (result) {
    > if (rc)
    > --
    > 2.4.3
    >
    > --
    > To unsubscribe, send a message with 'unsubscribe linux-mm' in
    > the body to majordomo@kvack.org. For more info on Linux MM,
    > see: http://www.linux-mm.org/ .
    > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

    \
     
     \ /
      Last update: 2015-09-16 05:21    [W:4.078 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site