lkml.org 
[lkml]   [2015]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 17/19] staging/lustre/o2iblnd: leak cmid in kiblnd_dev_need_failover
    Date
    From: Liang Zhen <liang.zhen@intel.com>

    cmid created by kiblnd_dev_need_failover should always be destroyed,
    however it is not the case in current implementation and we will leak
    cmid when this function detected a device failover.

    Signed-off-by: Liang Zhen <liang.zhen@intel.com>
    Reviewed-on: http://review.whamcloud.com/14603
    Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6480
    Reviewed-by: Isaac Huang <he.huang@intel.com>
    Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
    Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
    ---
    drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
    index c29d2ce..faa70f0 100644
    --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
    +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
    @@ -2228,13 +2228,10 @@ static int kiblnd_dev_need_failover(kib_dev_t *dev)
    return rc;
    }

    - if (dev->ibd_hdev->ibh_ibdev == cmid->device) {
    - /* don't need device failover */
    - rdma_destroy_id(cmid);
    - return 0;
    - }
    + rc = dev->ibd_hdev->ibh_ibdev != cmid->device; /* true for failover */
    + rdma_destroy_id(cmid);

    - return 1;
    + return rc;
    }

    int kiblnd_dev_failover(kib_dev_t *dev)
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-09-15 01:01    [W:6.071 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site