Messages in this thread | | | Date | Mon, 14 Sep 2015 09:50:20 +0200 | Subject | Re: [PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2 Square board | From | Javier Martinez Canillas <> |
| |
Hello Sjoerd,
On Mon, Sep 14, 2015 at 9:30 AM, Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote:
[snip]
>> > + >> > + vcc18_lcd: REG12 { >> > + regulator-name = "VCC18_LCD"; >> > + regulator-min-microvolt = >> > <1800000>; >> > + regulator-max-microvolt = >> > <1800000>; >> > + regulator-always-on; >> > + }; >> >> Should all these regulators really need to be always-on? > > Ideally not all of them, turning the ones that aren't needed off is > definately on my list of things to do (together with the other > pheripherals, leds, hw. keys etc). > > For the first patch i do prefer to keep them on so we can have get some > more testing with this board before fine-tuning those things (fwiw,
Ok.
> the rockchip evb board and others with essentially the same pmic setup > all also have them always-on)
Yes but I believe that's because it was easier and there are regulators on these boards that don't need to be always-on as well.
> -- > Sjoerd Simons > Collabora Ltd.
Best regards, Javier
| |