Messages in this thread | | | Date | Mon, 14 Sep 2015 11:35:23 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address |
| |
On Mon, Sep 14, 2015 at 08:15:23PM +0300, Jarkko Sakkinen wrote: > The command buffer address is necessarily not naturally aligned. > The hardware drops the entire read on some platforms and fills the > address with 1's. This patch fixes the issue by splitting the read > into two 32 bit reads.
Is this necessary? The packed attribution means that unaligned members are allowed and the compiler deals with it where necessary.
Jason
| |