Messages in this thread | | | Date | Mon, 14 Sep 2015 19:05:47 +0200 | From | Oleg Nesterov <> | Subject | Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set") |
| |
On 09/14, Kirill A. Shutemov wrote: > > Fix is below. I don't really like it, but I cannot find any better > solution.
Me too...
But this change "documents" the nasty special "vm_file && !vm_ops" case, and I am not sure how we can remove it later...
So perhaps we should change vma_is_anonymous() back to check ->fault too,
static inline bool vma_is_anonymous(struct vm_area_struct *vma) { - return !vma->vm_ops; + return !vma->vm_ops || !vma->vm_ops->fault; }
and remove the "vma->vm_file && !vma->vm_ops" checks in mmap_region() paths.
I dunno.
Oleg.
| |