Messages in this thread | | | Date | Mon, 14 Sep 2015 12:06:57 -0400 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH 22/39] nfsd: drop null test before destroy functions |
| |
Thanks, applying.--b.
On Sun, Sep 13, 2015 at 02:15:15PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ expression x; @@ > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x = NULL; > -} > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > fs/nfsd/nfscache.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c > index 46ec934..116940c 100644 > --- a/fs/nfsd/nfscache.c > +++ b/fs/nfsd/nfscache.c > @@ -217,10 +217,8 @@ void nfsd_reply_cache_shutdown(void) > drc_hashtbl = NULL; > drc_hashsize = 0; > > - if (drc_slab) { > - kmem_cache_destroy(drc_slab); > - drc_slab = NULL; > - } > + kmem_cache_destroy(drc_slab); > + drc_slab = NULL; > } > > /*
| |