lkml.org 
[lkml]   [2015]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/39] xhci: drop null test before destroy functions
    Date
    Remove unneeded NULL test.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@ expression x; @@
    -if (x != NULL)
    \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/usb/host/xhci-mem.c | 12 ++++--------
    1 file changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
    index 9a8c936..40618d1 100644
    --- a/drivers/usb/host/xhci-mem.c
    +++ b/drivers/usb/host/xhci-mem.c
    @@ -1829,24 +1829,20 @@ void xhci_mem_cleanup(struct xhci_hcd *xhci)
    for (i = 1; i < MAX_HC_SLOTS; ++i)
    xhci_free_virt_device(xhci, i);

    - if (xhci->segment_pool)
    - dma_pool_destroy(xhci->segment_pool);
    + dma_pool_destroy(xhci->segment_pool);
    xhci->segment_pool = NULL;
    xhci_dbg_trace(xhci, trace_xhci_dbg_init, "Freed segment pool");

    - if (xhci->device_pool)
    - dma_pool_destroy(xhci->device_pool);
    + dma_pool_destroy(xhci->device_pool);
    xhci->device_pool = NULL;
    xhci_dbg_trace(xhci, trace_xhci_dbg_init, "Freed device context pool");

    - if (xhci->small_streams_pool)
    - dma_pool_destroy(xhci->small_streams_pool);
    + dma_pool_destroy(xhci->small_streams_pool);
    xhci->small_streams_pool = NULL;
    xhci_dbg_trace(xhci, trace_xhci_dbg_init,
    "Freed small stream array pool");

    - if (xhci->medium_streams_pool)
    - dma_pool_destroy(xhci->medium_streams_pool);
    + dma_pool_destroy(xhci->medium_streams_pool);
    xhci->medium_streams_pool = NULL;
    xhci_dbg_trace(xhci, trace_xhci_dbg_init,
    "Freed medium stream array pool");


    \
     
     \ /
      Last update: 2015-09-13 15:01    [W:4.444 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site