Messages in this thread | | | Date | Sat, 12 Sep 2015 12:00:11 +0100 | From | Matt Fleming <> | Subject | Re: [PATCH 2/3] perf tests: Add arch tests |
| |
On Mon, 07 Sep, at 02:23:53PM, Jiri Olsa wrote: > On Sat, Sep 05, 2015 at 08:02:21PM +0100, Matt Fleming wrote: > > SNIP > > > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c > > index 8cf0601d1662..a1b2265eaf55 100644 > > --- a/tools/perf/tests/builtin-test.c > > +++ b/tools/perf/tests/builtin-test.c > > @@ -14,10 +14,17 @@ > > #include "parse-options.h" > > #include "symbol.h" > > > > -static struct test { > > - const char *desc; > > - int (*func)(void); > > -} tests[] = { > > +#if defined(__x86_64__) || defined(__i386__) > > +#include "arch-tests.h" > > +#else > > +static struct test arch_tests[] = { > > + { > > + .func = NULL, > > + }, > > +}; > > +#endif > > this could be defined as __weak array so we dont need to have #if above
Yeah, good idea. I'll make that change.
-- Matt Fleming, Intel Open Source Technology Center
| |