Messages in this thread | | | Date | Fri, 11 Sep 2015 18:52:58 +0800 | From | "Wangnan (F)" <> | Subject | Re: [PATCH 07/13] perf hists browser: Fixup the "cpu" column width calculation |
| |
On 2015/9/10 3:50, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo <acme@redhat.com> > > Since we were not setting it to at least 3 chars ('CPU'), it was being > reset to zero when recalculating the columns width when refreshing the > screen, in 'perf top'. Fix it.
Tested-by: Wang Nan <wangnan0@huawei.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: Borislav Petkov <bp@suse.de> > Cc: David Ahern <dsahern@gmail.com> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Kan Liang <kan.liang@intel.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Stephane Eranian <eranian@google.com> > Cc: Wang Nan <wangnan0@huawei.com> > Link: http://lkml.kernel.org/n/tip-iqcdnkkqm6sew06x01fbijmy@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > --- > tools/perf/util/hist.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 67b48616ab31..b3567a25f0c4 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -146,6 +146,7 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h) > hists__set_unres_dso_col_len(hists, HISTC_MEM_DADDR_DSO); > } > > + hists__new_col_len(hists, HISTC_CPU, 3); > hists__new_col_len(hists, HISTC_SOCKET, 6); > hists__new_col_len(hists, HISTC_MEM_LOCKED, 6); > hists__new_col_len(hists, HISTC_MEM_TLB, 22);
| |