lkml.org 
[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart
From
Date
On Thu, 2015-09-10 at 14:37 +0200, LABBE Corentin wrote:
> replace all
> if (netif_msg_type(priv)) dev_xxx(priv->devices, ...)
> by the simplier macro netif_xxx(priv, hw, priv->dev, ...)

Thanks. Trivia:

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[]
> @@ -733,10 +735,9 @@ static void stmmac_adjust_link(struct net_device *dev)
> stmmac_hw_fix_mac_speed(priv);
> break;
> default:
> - if (netif_msg_link(priv))
> - netdev_warn(priv->dev,
> - "%s: Speed (%d) not 10/100\n",
> - dev->name, phydev->speed);
> + netif_warn(priv, link, priv->dev,
> + "%s: Speed (%d) not 10/100\n",
> + dev->name, phydev->speed);

Maybe add another patch removing dev->name where used
in logging as it's likely redundant.

> @@ -1038,18 +1039,15 @@ static int init_dma_desc_rings(struct net_device *dev, gfp_t flags)
>
> priv->dma_buf_sz = bfsize;
>
> - if (netif_msg_probe(priv))
> - netdev_dbg(priv->dev, "%s: txsize %d, rxsize %d, bfsize %d\n",
> - __func__, txsize, rxsize, bfsize);
> + netif_dbg(priv, probe, priv->dev, "%s: txsize %d, rxsize %d, bfsize %d\n",
> + __func__, txsize, rxsize, bfsize);

And another removing __func__ from the _dbg uses as
it's relatively low value and dynamic debug can add it.




\
 
 \ /
  Last update: 2015-09-10 18:41    [W:1.366 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site