Messages in this thread | | | Date | Thu, 10 Sep 2015 12:06:04 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 5/6] sched/fair: Get rid of scaling utilization by capacity_orig |
| |
On Thu, Sep 10, 2015 at 03:07:48AM +0800, Yuyang Du wrote: > On Tue, Sep 08, 2015 at 02:52:05PM +0200, Peter Zijlstra wrote: > > > > +#if (SCHED_LOAD_SHIFT - SCHED_LOAD_RESOLUTION) != 10 || SCHED_CAPACITY_SHIFT != 10 > > +#error "load tracking assumes 2^10 as unit" > > +#endif > > + > > Sorry for late response. I might already missed somthing. > > But I got a bit lost here, with: > > #define SCHED_LOAD_SHIFT (10 + SCHED_LOAD_RESOLUTION) > #define SCHED_CAPACITY_SHIFT 10 > > the #if is certainly false.
That is intended, triggering #error would be 'bad'.
The reason for this bit is to raise a stink if someone 'accidentally' changes one of these values and expects things to just work.
| |