lkml.org 
[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/6] Staging: iio: addac: adt7316.c : Prefer using BIT macro
    Date
    This patch replaces bit shifting on 1 with the BIT(x) macro
    as it's extensively used by other function in this driver.

    This was done with coccinelle:
    @@ int g; @@

    -(1 << g)
    +BIT(g)

    Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
    ---
    drivers/staging/iio/addac/adt7316.c | 14 +++++++-------
    1 file changed, 7 insertions(+), 7 deletions(-)

    diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
    index 5b11b42..a1dd745 100644
    --- a/drivers/staging/iio/addac/adt7316.c
    +++ b/drivers/staging/iio/addac/adt7316.c
    @@ -1756,43 +1756,43 @@ static irqreturn_t adt7316_event_handler(int irq, void *private)
    stat1 &= 0x1F;

    time = iio_get_time_ns();
    - if (stat1 & (1 << 0))
    + if (stat1 & BIT(0))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
    IIO_EV_TYPE_THRESH,
    IIO_EV_DIR_RISING),
    time);
    - if (stat1 & (1 << 1))
    + if (stat1 & BIT(1))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
    IIO_EV_TYPE_THRESH,
    IIO_EV_DIR_FALLING),
    time);
    - if (stat1 & (1 << 2))
    + if (stat1 & BIT(2))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1,
    IIO_EV_TYPE_THRESH,
    IIO_EV_DIR_RISING),
    time);
    - if (stat1 & (1 << 3))
    + if (stat1 & BIT(3))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1,
    IIO_EV_TYPE_THRESH,
    IIO_EV_DIR_FALLING),
    time);
    - if (stat1 & (1 << 5))
    + if (stat1 & BIT(5))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 1,
    IIO_EV_TYPE_THRESH,
    IIO_EV_DIR_EITHER),
    time);
    - if (stat1 & (1 << 6))
    + if (stat1 & BIT(6))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 2,
    IIO_EV_TYPE_THRESH,
    IIO_EV_DIR_EITHER),
    time);
    - if (stat1 & (1 << 7))
    + if (stat1 & BIT(7))
    iio_push_event(indio_dev,
    IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 3,
    IIO_EV_TYPE_THRESH,
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-09-10 06:41    [W:4.078 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site