Messages in this thread | | | Date | Thu, 10 Sep 2015 10:35:54 +0200 | From | Corinna Vinschen <> | Subject | Re: [PATCH v2] r8169: Fix sleeping function called during get_stats64 |
| |
On Sep 9 20:31, David Miller wrote: > From: Corinna Vinschen <vinschen@redhat.com> > Date: Wed, 9 Sep 2015 23:16:40 +0200 > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031 > > Fixes: 6e85d5ad36a26debc23a9a865c029cbe242b2dc8 > > > > Based on the discussion starting at > > http://www.spinics.net/lists/netdev/msg342193.html > > > > Tested locally on RTL8168evl/8111evl with various concurrent processes > > accessing /proc/net/dev while changing the link state as well as > > removing/reloading the r8169 module. > > > > Signed-off-by: Corinna Vinschen <vinschen@redhat.com> > > Please address Francois's minor feedback, camelcase drives me nuts > too FWIW :-)
Haha, with pleasure. I don't like them much either. I just used them to align to the original code, which uses camel back for the rx/tx descriptor ring buffers allocated the same way.
I'll send a v3 in a minute which fixes all of Francois points.
Thanks, Corinna [unhandled content-type:application/pgp-signature] | |