Messages in this thread | | | Subject | Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn | From | Joe Perches <> | Date | Tue, 01 Sep 2015 13:37:18 -0700 |
| |
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > Return value would give clear information about the actual root-cause > of the failure.
I'm not sure why that is as nearly every error path in sdhci_add_host emits a message.
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c [] > @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) > > ret = sdhci_add_host(host); > if (ret) { > - dev_err(&pdev->dev, "failed to add host\n"); > + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); > goto err_add_host; > } >
If this is really desirable, there are many other callers of sdhci_add_host with error messages just like this one.
| |