lkml.org 
[lkml]   [2015]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn
    From
    Date
    On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
    > Return value would give clear information about the actual root-cause
    > of the failure.

    I'm not sure why that is as nearly every error path in
    sdhci_add_host emits a message.

    > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
    []
    > @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
    >
    > ret = sdhci_add_host(host);
    > if (ret) {
    > - dev_err(&pdev->dev, "failed to add host\n");
    > + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
    > goto err_add_host;
    > }
    >

    If this is really desirable, there are many other callers of
    sdhci_add_host with error messages just like this one.



    \
     
     \ /
      Last update: 2015-09-01 23:01    [W:2.776 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site