lkml.org 
[lkml]   [2015]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracepoint: don't make assumptions about length of string on task rename
On Tue, 01 Sep 2015 11:07:32 -0400
Sasha Levin <sasha.levin@oracle.com> wrote:


> > Also, as the memcpy was just faster than a strcpy, the static length
> > was used. Perhaps we should convert that to a dynamic length string.
> > But that should be a separate patch as this one fixes a possible bug,
> > and the conversion to a dynamic string is just an enhancement.
>
> That'll slow things down for the common case, no?

Not really that much.

The comms should have been dynamic strings too, but the sched_switch
tracepoint (the one others have been copied from) was created before we
had dynamic strings for tracepoints.

-- Steve



\
 
 \ /
  Last update: 2015-09-01 17:41    [W:0.034 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site