Messages in this thread Patch in this message | | | From | Robert Dolca <> | Subject | [PATCH v2 5/9] nfc: nci: Do not call post_setup when setup fails | Date | Tue, 1 Sep 2015 17:54:24 +0300 |
| |
The driver should know that it can continue with post setup where setup left off. Being able to execute post_setup when setup fails may force the developer to keep this state in the driver.
Signed-off-by: Robert Dolca <robert.dolca@intel.com> --- net/nfc/nci/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index e2bd5f4..29607f9 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -402,9 +402,8 @@ static int nci_open_device(struct nci_dev *ndev) msecs_to_jiffies(NCI_INIT_TIMEOUT)); } - if (ndev->ops->post_setup) { + if (!rc && ndev->ops->post_setup) rc = ndev->ops->post_setup(ndev); - } if (!rc) { rc = __nci_request(ndev, nci_init_complete_req, 0, -- 1.9.1
| |