Messages in this thread | | | Date | Tue, 1 Sep 2015 12:40:15 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf tools: Fix random building error |
| |
On Tue, Sep 01, 2015 at 09:24:14AM +0300, Adrian Hunter wrote: > On 01/09/15 08:56, Wang Nan wrote: > > I hit following building error randomly: > > Random presumably because there is a race to use/create the directory by > different make jobs (i.e. -j option). > > > > > ... > > /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory > > ... > > LINK /path/to/kernel/buildperf/plugin_mac80211.so > > LINK /path/to/kernel/buildperf/plugin_kmem.so > > LINK /path/to/kernel/buildperf/plugin_xen.so > > LINK /path/to/kernel/buildperf/plugin_hrtimer.so > > In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0: > > util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory > > #include "inat-tables.c" > > ^ > > compilation terminated. > > make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1 > > make[4]: *** Waiting for unfinished jobs.... > > LINK /path/to/kernel/buildperf/plugin_function.so > > > > This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to > > generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but > > forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory. > > > > This patch fixes it by adding $(call rule_mkdir) like other similar rules. > > > > Signed-off-by: Wang Nan <wangnan0@huawei.com> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > > Cc: Adrian Hunter <adrian.hunter@intel.com> > > Looks ok to me. Jiri?
right, each separate rule needs to have this
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
| |