lkml.org 
[lkml]   [2015]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs
    On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote:

    > The smd structures are always in little endian, but the smd
    > driver is not capable of being used on big endian CPUs. Annotate
    > the little endian data members and update the code to do the
    > proper byte swapping.
    >

    I think this looks good, but I think it would be better to reference
    the 8-bit entries of the info struct as "flags" rather than INFO8s.

    Could you please change the name of the macros to
    {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to
    follow?

    Regards,
    Bjorn


    \
     
     \ /
      Last update: 2015-09-01 07:41    [W:3.989 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site