Messages in this thread | | | Date | Sat, 8 Aug 2015 01:02:05 -0800 | From | Kent Overstreet <> | Subject | Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios |
| |
On Sat, Aug 08, 2015 at 10:52:24AM +0200, Hannes Reinecke wrote: > Wouldn't it be easier to move both max_write_same_sectors and > max_discard sectors to 64 bit (ie to type sector_t) and be done with the > overflow? > Seems to me this is far too much coding around self-imposed restrictions...
It's bio->bi_iter.bi_size that would have to be increased to 64 bits. Which I suppose wouldn't actually increase the size of struct bio (when sector_t is 64 bits), since struct bvec_iter has padding right now...
| |