| Date | Sat, 8 Aug 2015 12:18:55 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function. |
| |
On Saturday 08 August 2015 11:23 AM, Alexander Holler wrote: > Hello, > > this patch killed the musb-host functionality on my classic Beagleboard (rev > c4). Symptom was that it there was a message I don't remember and the attached > device didn't enumerate anymore (likely because of missing power, but I'm not > sure). > > A simple revert has fixed it, I haven't looked further into the problem.
Neil Brown, how was this tested?
-Kishon
> > Regards, > > Alexander Holler > > Am 31.07.2015 um 21:39 schrieb Greg Kroah-Hartman: >> 4.1-stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: NeilBrown <neil@brown.name> >> >> commit 4724e27114c4a7eceeee07db227a17fcab6f165c upstream. >> >> The USB phy should initialize with power-off, and will be powered on >> by the USB system when a cable connection is detected. >> >> Having this pm_runtime_get_sync() during probe causes the phy to >> *always* be powered on. >> Removing it returns to sensible power management. >> >> Fixes: 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4 >> Signed-off-by: NeilBrown <neil@brown.name> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> >> --- >> drivers/phy/phy-twl4030-usb.c | 1 - >> 1 file changed, 1 deletion(-) >> >> --- a/drivers/phy/phy-twl4030-usb.c >> +++ b/drivers/phy/phy-twl4030-usb.c >> @@ -711,7 +711,6 @@ static int twl4030_usb_probe(struct plat >> pm_runtime_use_autosuspend(&pdev->dev); >> pm_runtime_set_autosuspend_delay(&pdev->dev, 2000); >> pm_runtime_enable(&pdev->dev); >> - pm_runtime_get_sync(&pdev->dev); >> >> /* Our job is to use irqs and status from the power module >> * to keep the transceiver disabled when nothing's connected. >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> >
|