lkml.org 
[lkml]   [2015]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons
From
Date
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote:
[]
> > Is it ok to keep these codes and add comments like:

It's your code Yu, do whatever you think appropriate.

> > /*
> > * When a button(power button/volume button/home button) is
> > * pressed down or released, different ACPI notification codes
> > * will be generated. We can distinguish different event code
> > * and value of buttons by these notification codes, then pass
> > * (EV_KEY, event code(key_code), value(pressed)) to input layer.
> > */
>
> The commentary is useful regardless. However, I suspect Joe was
> referring to the approach pairing the PRESS and RELEASE cases?
>

True.

btw Darren, your computer's email time setting seems off.




\
 
 \ /
  Last update: 2015-08-06 21:21    [W:0.065 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site