Messages in this thread | | | Date | Thu, 6 Aug 2015 16:04:32 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects |
| |
Hi Vivien
Thanks for splitting up the big patch. This it is much easier to review now.
Is this patch git bisectable?
Clearly after this patch, but before all the other patches are in, we will not be programming the hardware. The call into the driver is removed here, but the replacement is added later. But is the EOPNOTSUP enough that the system keeps working, by falling back to software?
The two driver APIs are very similar, the main difference being the MAC address. Can you do the refactoring first, and then make the API change. That means we can test each patch individually, and have proper git bisectability.
Thanks Andrew
| |