Messages in this thread | | | Date | Mon, 31 Aug 2015 17:47:11 -0700 | Subject | Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window | From | Linus Torvalds <> |
| |
Hmm:
On Fri, Aug 14, 2015 at 4:57 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: > > Xiao Guangrong (9): > KVM: MMU: fully check zero bits for sptes
The above commit causes an annoying new compiler warning.
The warning is bogus ("variable 'leaf' possibly uninitialized"), because the use of the variable is protected by the 'bool reserved' flag, but gcc is apparently not smart enough to understand that.
Since bogus warnings cause people to possibly ignore the *real* warnings, this should be fixed. Maybe the code should get rid of that 'reserved' flag, and instead initialize "leaf" to zero, and use that as the flag instead (since zero isn't a valid level)? That would actually avoid an extra variable, and would get rid of the warning.
Hmm?
Linus
| |