Messages in this thread | | | Date | Thu, 27 Aug 2015 19:57:56 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v6 1/2] drivers: watchdog: add a driver to support SAMA5D4 watchdog timer |
| |
On 08/27/2015 06:30 PM, Yang, Wenyou wrote: > > >> -----Original Message----- >> From: Guenter Roeck [mailto:linux@roeck-us.net] >> Sent: 2015年8月7日 23:26 >> To: Yang, Wenyou; wim@iguana.be; robh+dt@kernel.org; pawel.moll@arm.com; >> mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org >> Cc: sylvain.rochet@finsecur.com; Ferre, Nicolas; boris.brezillon@free- >> electrons.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> watchdog@vger.kernel.org >> Subject: Re: [PATCH v6 1/2] drivers: watchdog: add a driver to support SAMA5D4 >> watchdog timer >> >> On 08/06/2015 03:16 AM, Wenyou Yang wrote: >>> >From SAMA5D4, the watchdog timer is upgrated with a new feature, >>> which is describled as in the datasheet, "WDT_MR can be written until >>> a LOCKMR command is issued in WDT_CR". >>> That is to say, as long as the bootstrap and u-boot don't issue a >>> LOCKMR command, WDT_MR can be written more than once in the driver. >>> >>> So the SAMA5D4 watchdog driver's implementation is different from the >>> at91sam9260 watchdog driver implemented in file at91sam9_wdt.c. >>> The user application open the device file to enable the watchdog timer >>> hardware, and close to disable it, and set the watchdog timer timeout >>> by seting WDV and WDD fields of WDT_MR register, and ping the watchdog >>> by issuing WDRSTT command to WDT_CR register with hard-coded key. >>> >>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> >> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Hi Vim, > > Can this patch series be merged? Could you please? > It is included in the pull request I sent to Wim last week.
Guenter
| |