Messages in this thread | | | Date | Thu, 27 Aug 2015 14:25:06 -0700 (PDT) | Subject | Re: [PATCH -next v3 2/2] smsc911x: Ignore error return from device_get_phy_mode() | From | David Miller <> |
| |
From: Guenter Roeck <linux@roeck-us.net> Date: Wed, 26 Aug 2015 20:27:05 -0700
> Commit 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is > configured or used") introduces an error check for the return value from > device_get_phy_mode() and bails out if there is an error. Unfortunately, > there are configurations where no phy is configured. Those configurations > now fail. > > To fix the problem, accept error returns from device_get_phy_mode(), > and use the return value from device_property_read_u32() to determine > if there is a suitable firmware interface to read the configuration. > > Fixes: 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is configured or used") > Tested-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied.
| |