Messages in this thread | | | From | "Liang, Kan" <> | Subject | RE: [PATCH RFC 02/10] perf,tools: Support new sort type --socket | Date | Thu, 27 Aug 2015 18:29:47 +0000 |
| |
> > On Mon, Aug 24, 2015 at 09:30:21PM +0200, Jiri Olsa wrote: > > On Mon, Aug 24, 2015 at 04:47:12PM +0000, Liang, Kan wrote: > > > > > > > > > > On Mon, Aug 24, 2015 at 02:22:08PM +0000, Liang, Kan wrote: > > > > > > > > > > > > On Fri, Aug 21, 2015 at 08:25:24PM +0000, Liang, Kan wrote: > > > > > > > > > > > > SNIP > > > > > > > > > > > > > > > > > > > > > > we need global topology information in perf.data and use > > > > > > > > the mapping from there, we can't use current server info > > > > > > > > > > > > > > > > we currently store core_siblings_list and > > > > > > > > thread_siblings_list, in topology FEATURE, which is > > > > > > > > probably not enough > > > > > > > > > > > > > > > > > > > > > > core_siblings_list includes the cpu list in the same socket. > > > > > > > thread_siblings_list includes the cpu list in the same core. > > > > > > > numa_nodes includes the cpu list for each node. > > > > > > > > > > > > > > It looks we have enough data from topology FEATURE. > > > > > > > > > > > > hum, haven't hecked deeply.. how will you get core id for cpu? > > > > > > > > > > > > > > > > from thread_siblings_list. > > > > > I just noticed that svg_build_topology_map did the similar > > > > > thing to get topology map for timechart from perf header. > > > > > > > > could you please provide both functions then cpu -> core, cpu -> > > > > socket > > > > > > > > > > Do you mean something like this? > > > Store cpu->socket and cpu->core in perf_session_env. > > > > yep, seems ok > > any chance you could send out this one? I'd need to use it in my other stuff >
Ok I will send out this patch as a separate patch first.
| |