Messages in this thread | | | Subject | Re: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons | From | Joe Perches <> | Date | Wed, 26 Aug 2015 05:04:01 -0700 |
| |
On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote: > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote: > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can > > not detect these buttons on it. According to bios implementation, > > Surface Pro 3 encapsulates these buttons in a device named "VGBI", > > with _HID "MSHW0028". When any of the buttons is pressed, a specify > > ACPI notification code for this button will be delivered to "VGBI". For > > example, if power button is pressed down, ACPI notification code of 0xc6 > > will be sent by Notify(VGBI, 0xc6). [] > Joe, you provided a lot of review, are you happy with this version?
It looks fine.
Thanks for picking the other little nits too Darren.
| |