lkml.org 
[lkml]   [2015]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/6] fix android/sync.c several coding style issues
    Date
    Corrections based on checkpatch.pl with --strict
    1) Comparison to NULL could be written "!*"
    2) Alignment should match open parenthesis

    Signed-off-by: Peng Sun <sironhide0null@gmail.com>
    ---
    drivers/staging/android/sync.c | 22 +++++++++++-----------
    1 file changed, 11 insertions(+), 11 deletions(-)

    diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
    index f83e00c..e0c1acb 100644
    --- a/drivers/staging/android/sync.c
    +++ b/drivers/staging/android/sync.c
    @@ -43,7 +43,7 @@ struct sync_timeline *sync_timeline_create(const struct sync_timeline_ops *ops,
    return NULL;

    obj = kzalloc(size, GFP_KERNEL);
    - if (obj == NULL)
    + if (!obj)
    return NULL;

    kref_init(&obj->kref);
    @@ -130,7 +130,7 @@ struct sync_pt *sync_pt_create(struct sync_timeline *obj, int size)
    return NULL;

    pt = kzalloc(size, GFP_KERNEL);
    - if (pt == NULL)
    + if (!pt)
    return NULL;

    spin_lock_irqsave(&obj->child_list_lock, flags);
    @@ -155,7 +155,7 @@ static struct sync_fence *sync_fence_alloc(int size, const char *name)
    struct sync_fence *fence;

    fence = kzalloc(size, GFP_KERNEL);
    - if (fence == NULL)
    + if (!fence)
    return NULL;

    fence->file = anon_inode_getfile("sync_fence", &sync_fence_fops,
    @@ -193,7 +193,7 @@ struct sync_fence *sync_fence_create(const char *name, struct sync_pt *pt)
    struct sync_fence *fence;

    fence = sync_fence_alloc(offsetof(struct sync_fence, cbs[1]), name);
    - if (fence == NULL)
    + if (!fence)
    return NULL;

    fence->num_fences = 1;
    @@ -215,7 +215,7 @@ struct sync_fence *sync_fence_fdget(int fd)
    {
    struct file *file = fget(fd);

    - if (file == NULL)
    + if (!file)
    return NULL;

    if (file->f_op != &sync_fence_fops)
    @@ -262,7 +262,7 @@ struct sync_fence *sync_fence_merge(const char *name,
    unsigned long size = offsetof(struct sync_fence, cbs[num_fences]);

    fence = sync_fence_alloc(size, name);
    - if (fence == NULL)
    + if (!fence)
    return NULL;

    atomic_set(&fence->status, num_fences);
    @@ -313,7 +313,7 @@ struct sync_fence *sync_fence_merge(const char *name,
    EXPORT_SYMBOL(sync_fence_merge);

    int sync_fence_wake_up_wq(wait_queue_t *curr, unsigned mode,
    - int wake_flags, void *key)
    + int wake_flags, void *key)
    {
    struct sync_fence_waiter *wait;

    @@ -353,7 +353,7 @@ int sync_fence_wait_async(struct sync_fence *fence,
    EXPORT_SYMBOL(sync_fence_wait_async);

    int sync_fence_cancel_async(struct sync_fence *fence,
    - struct sync_fence_waiter *waiter)
    + struct sync_fence_waiter *waiter)
    {
    unsigned long flags;
    int ret = 0;
    @@ -583,14 +583,14 @@ static long sync_fence_ioctl_merge(struct sync_fence *fence, unsigned long arg)
    }

    fence2 = sync_fence_fdget(data.fd2);
    - if (fence2 == NULL) {
    + if (!fence2) {
    err = -ENOENT;
    goto err_put_fd;
    }

    data.name[sizeof(data.name) - 1] = '\0';
    fence3 = sync_fence_merge(data.name, fence, fence2);
    - if (fence3 == NULL) {
    + if (!fence3) {
    err = -ENOMEM;
    goto err_put_fence2;
    }
    @@ -666,7 +666,7 @@ static long sync_fence_ioctl_fence_info(struct sync_fence *fence,
    size = 4096;

    data = kzalloc(size, GFP_KERNEL);
    - if (data == NULL)
    + if (!data)
    return -ENOMEM;

    strlcpy(data->name, fence->name, sizeof(data->name));
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-08-25 09:01    [W:2.889 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site