Messages in this thread | | | From | Jose Rivera <> | Subject | RE: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver | Date | Tue, 25 Aug 2015 18:48:21 +0000 |
| |
> -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > Sent: Thursday, August 20, 2015 2:35 AM > To: Rivera Jose-B46482 > Cc: gregkh@linuxfoundation.org; arnd@arndb.de; > devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Yoder Stuart- > B08248; katz Itai-RM05202; Wood Scott-B07421; agraf@suse.de; Hamciuc > Bogdan-BHAMCIU1; Marginean Alexandru-R89243; Sharma Bhupesh-B45370; Erez > Nir-RM30794; Schmitt Richard-B43082 > Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus > driver > > On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote: > > Since signatures of flib functions have changed, we had to change all > > the corresponding calls in the MC bus driver > > > > What does upgrade mean here? I feel like this is the kind of patch we > reject without reading the patch because the description is too vague and > you can tell from the diff stats that it is going to be too huge to > review. We will do some refactoring to make this easier to review.
Thanks,
german > > I looked at the first few lines and we are making a ball of changes. > Copyright notices, adding function parameters, renaming functions. This > needs to be explained a lot better and probably split into multiple > patches. > > Btw, the trees are closed for the next 3-4 weeks until after 4.3-rc2 is > released. > > regards, > dan carpenter
| |