Messages in this thread | | | Date | Mon, 24 Aug 2015 18:53:56 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes |
| |
Hello, Dave.
On Tue, Aug 25, 2015 at 08:27:20AM +1000, Dave Chinner wrote: > > I'm still a bit confused. What prevents the following from happening? > > > > 1. io completion of last dirty page of an inode and work item for > > xfs_setfilesize() is queued. > > > > 2. inode removed from dirty list. > > The inode has already been removed from the dirty list - that > happens at inode writeback submission time, not IO completion.
Ah, yeah, right, somehow was thinking requeue_io() was being called from completion path. That's where I was confused.
Thanks.
-- tejun
| |