Messages in this thread | | | Date | Mon, 24 Aug 2015 12:59:02 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success. |
| |
On Mon, 24 Aug 2015 16:56:13 +0800 Sean Fu <fxinrong@gmail.com> wrote:
> when the input argument "count" including the terminating byte "\0", > The write system call return EINVAL on proc file. > But it return success on regular file. > > E.g. Writting two bytes ("1\0") to "/proc/sys/net/ipv4/conf/eth0/rp_filter". > write(fd, "1\0", 2) return EINVAL.
And what would do that? What tool broke because of this?
echo 1 > /proc/sys/net/ipv4/conf/eth0/rp_filter
works just fine. strlen("string") would not include the nul character. The only thing I could think of would be a sizeof(str), but then that would include someone hardcoding an integer in a string, like:
char val[] = "1"
write(fd, val, sizeof(val));
Again, what tool does that?
If there is a tool out in the wild that use to work on 2.6 (and was running on 2.6 then, and not something that was created after that change), then we can consider this fix.
-- Steve
| |