Messages in this thread | | | Date | Mon, 24 Aug 2015 10:20:27 +0200 | From | Jacek Anaszewski <> | Subject | Re: [PATCH v2] leds: syscon: Correct check for syscon_node_to_regmap() errors |
| |
On 08/18/2015 09:25 PM, Bjorn Andersson wrote: > syscon_node_to_regmap() returns a regmap or an ERR_PTR(). > > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > --- > > Changes since v1: > - Propagate the error > > drivers/leds/leds-syscon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c > index d1660b039812..b88900d721e4 100644 > --- a/drivers/leds/leds-syscon.c > +++ b/drivers/leds/leds-syscon.c > @@ -83,9 +83,9 @@ static int syscon_led_probe(struct platform_device *pdev) > return -ENODEV; > } > map = syscon_node_to_regmap(parent->of_node); > - if (!map) { > + if (IS_ERR(map)) { > dev_err(dev, "no regmap for syscon LED parent\n"); > - return -ENODEV; > + return PTR_ERR(map); > } > > sled = devm_kzalloc(dev, sizeof(*sled), GFP_KERNEL); >
Merged, thanks.
-- Best Regards, Jacek Anaszewski
| |