lkml.org 
[lkml]   [2015]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/18] mtd: dataflash: Export OF module alias information
    Date
    The SPI core always reports the MODALIAS uevent as "spi:<modalias>"
    regardless of the mechanism that was used to register the device
    (i.e: OF or board code) and the table that is used later to match
    the driver with the device (i.e: SPI id table or OF match table).

    So drivers needs to export the SPI id table and this be built into
    the module or udev won't have the necessary information to autoload
    the needed driver module when the device is added.

    But this means that OF-only drivers needs to have both OF and SPI id
    tables that have to be kept in sync and also the dev node compatible
    manufacturer prefix is stripped when reporting the MODALIAS. Which can
    lead to issues if two vendors use the same SPI device name for example.

    To avoid the above, the SPI core behavior may be changed in the future
    to not require an SPI device table for OF-only drivers and report the
    OF module alias. So, it's better to also export the OF table even when
    is unused now to prevent breaking module loading when the core changes.

    Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
    ---

    drivers/mtd/devices/mtd_dataflash.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
    index 0099aba72a8b..df6f61137376 100644
    --- a/drivers/mtd/devices/mtd_dataflash.c
    +++ b/drivers/mtd/devices/mtd_dataflash.c
    @@ -102,6 +102,7 @@ static const struct of_device_id dataflash_dt_ids[] = {
    { .compatible = "atmel,dataflash", },
    { /* sentinel */ }
    };
    +MODULE_DEVICE_TABLE(of, dataflash_dt_ids);
    #endif

    /* ......................................................................... */
    --
    2.4.3


    \
     
     \ /
      Last update: 2015-08-20 09:41    [W:2.642 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site