Messages in this thread | | | Date | Wed, 19 Aug 2015 23:03:30 +0200 | From | Ralf Baechle <> | Subject | Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API |
| |
On Sun, Aug 09, 2015 at 02:21:11PM +0200, Hauke Mehrtens wrote: > Date: Sun, 09 Aug 2015 14:21:11 +0200 > From: Hauke Mehrtens <hauke@hauke-m.de> > To: Alban Bedel <albeu@free.fr>, linux-mips@linux-mips.org, Ralf Baechle > <ralf@linux-mips.org> > CC: Andrew Bresticker <abrestic@chromium.org>, Qais Yousef > <qais.yousef@imgtec.com>, Wolfram Sang <wsa@the-dreams.de>, Sergey > Ryazanov <ryazanov.s.a@gmail.com>, Gabor Juhos <juhosg@openwrt.org>, > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API > Content-Type: text/plain; charset=windows-1252 > > On 04/19/2015 02:30 PM, Alban Bedel wrote: > > Make the code simpler and open the way for device tree clocks. > > > > Signed-off-by: Alban Bedel <albeu@free.fr> > > --- > > arch/mips/Kconfig | 1 + > > arch/mips/ath79/clock.c | 29 ++--------------------------- > > 2 files changed, 3 insertions(+), 27 deletions(-) > > > > I think this should be send at least to stable 4.1, because it fixes a > linking problem we are seeing in OpenWrt. > > ath79 does not export clk_set_rate() and clk_round_rate(), but some > drivers are using it and they are not using the inline dummy method, > because CONFIG_HAVE_CLK is set for ath79. > > ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined! > ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined! > ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
Ok. Will post the the patch in a separate email.
Ralf
| |