Messages in this thread | | | Date | Wed, 19 Aug 2015 15:44:37 -0700 | Subject | Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h | From | Ben Zhang <> |
| |
This patch is not really needed. The build failure on our v3.18-based kernel is fixed by cherry-picking commit 332fd7c4fef5 ("genirq: Generic chip: Change irq_reg_{readl,writel} arguments") which is actually a functional no-op. This patch could help prevent future build failure in case linux/io.h is later removed from linux/irq.h. Since the irq-gic-v3 driver uses the read/write io functions, it might be better to include linux/io.h explicitly.
Thanks, Ben
On Wed, Aug 19, 2015 at 2:13 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > On Fri, 7 Aug 2015, Ben Zhang wrote: >> Mainline build is fine because commit 332fd7c4fef5("genirq: Generic >> chip: Change irq_reg_{readl,writel} arguments") landed before the >> timecounter patch, and it creates a new include path to the io.h >> header: >> arch/arm64/include/asm/io.h >> include/linux/io.h >> include/linux/irq.h >> include/linux/of_irq.h >> drivers/irqchip/irq-gic-v3.c > > And why do we need to include it once more then? > > Thanks, > > tglx
| |