lkml.org 
[lkml]   [2015]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 0/2] kconfig: warn of unhandled characters in Kconfig commands
From
Date
On 2015-07-20 10:54, Ulf Magnusson wrote:
> On Sun, Jul 12, 2015 at 09:41:49AM +0200, Andreas Ruprecht wrote:
>> This patchset changes the lexer file to emit a warning if any unhandled
>> characters are found in the input. So far, Kconfig options like
>>
>> +config FOO
>> bool
>> [...]
>>
>> (note the wrong '+'!) were parsed without a warning. As simply adding a
>> warning for '.' produces lots of warnings as occasionally '---help---'
>> is used instead of 'help' (and thus '-' is recognized as an unhandled
>> character), we need to handle '---help---' separately.
>>
>> Changes to v1:
>> - add '---help---' in zconf.gperf instead of special casing
>> it in zconf.l
>>
>> Changes to v2:
>> - Do no constify char parameter to warn_ignored_character
>> - Shorten rule definitions for '.'
>>
>> Changes to v3:
>> - spaces -> tabs in zconf.gperf
>>
>> Andreas Ruprecht (2):
>> kconfig: warn of unhandled characters in Kconfig commands
>> kconfig: Regenerate shipped zconf.{hash,lex}.c files
>>
>> scripts/kconfig/zconf.gperf | 1 +
>> scripts/kconfig/zconf.hash.c_shipped | 58 ++++---
>> scripts/kconfig/zconf.l | 20 ++-
>> scripts/kconfig/zconf.lex.c_shipped | 325 +++++++++++++++++------------------
>> 4 files changed, 204 insertions(+), 200 deletions(-)
>>
>> --
>> 1.9.1
>>
>
> For what it's worth:
>
> Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com>
> Tested-by: Ulf Magnusson <ulfalizer@gmail.com>

Applied to kbuild.git#kconfig.

Michal



\
 
 \ /
  Last update: 2015-08-19 17:21    [W:0.096 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site