Messages in this thread Patch in this message | | | From | Adrian Hunter <> | Subject | [PATCH 3/3] perf tools: Fix buildid processing | Date | Wed, 19 Aug 2015 17:29:21 +0300 |
| |
After recording, 'perf record' post-processes the data to determine which buildids are needed. That processing must process the data in time order, if possible, because otherwise dependent events, like forks and mmaps, will not make sense.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- tools/perf/builtin-record.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index de165a1b9240..f36b88938499 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -500,6 +500,15 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) return -1; } + /* + * Normally perf_session__new would do this, but it doesn't have the + * evlist. + */ + if (rec->tool.ordered_events && !perf_evlist__sample_id_all(rec->evlist)) { + dump_printf("WARNING: No sample_id_all support, falling back to unordered processing\n"); + rec->tool.ordered_events = false; + } + fd = perf_data_file__fd(file); rec->session = session; @@ -965,9 +974,11 @@ static struct record record = { .tool = { .sample = process_sample_event, .fork = perf_event__process_fork, + .exit = perf_event__process_exit, .comm = perf_event__process_comm, .mmap = perf_event__process_mmap, .mmap2 = perf_event__process_mmap2, + .ordered_events = true, }, }; -- 1.9.1
| |