Messages in this thread | | | Date | Wed, 19 Aug 2015 14:00:12 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/6] mfd: Add MFD_CROS_EC dependencies |
| |
On Wed, 19 Aug 2015, Javier Martinez Canillas wrote:
> The MFD_CROS_EC symbol select CHROME_PLATFORMS and CROS_EC_PROTO but > that caused a Kconfig unmet direct dependencies warning since these > symbols could only be selected for X86 || ARM. > > The fix it, the CHROME_PLATFORMS dependencies were relexed on commit > d12bbcd3ea44 ("platform/chrome: Don't make CHROME_PLATFORMS depends > on X86 || ARM") but that was found to be wrong and the correct fix > is to add the needed dependencies to the MFD_CROS_EC config symbol. > > There are only x86 and ARM based Chromebooks so to avoid showing up > the config option on unsupported platforms, make the symbol depend on > these architectures. Also add a || COMPILE_TEST so it can have build > coverage on other platforms. > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3dfe7bd4022f..feebc750aadf 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -97,6 +97,7 @@ config MFD_CROS_EC > select MFD_CORE > select CHROME_PLATFORMS > select CROS_EC_PROTO > + depends on X86 || ARM || COMPILE_TEST > help > If you say Y here you get support for the ChromeOS Embedded > Controller (EC) providing keyboard, battery and power services.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |