Messages in this thread | | | Date | Wed, 19 Aug 2015 15:30:21 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH 1/9] staging: most: NULL comparison style |
| |
On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote: > On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > According to the kernel coding style the NULL check should not be > > written as [variable] == NULL or [variable] != NULL. > > It seems this not documented in Documentation/CodingStyle . Yes, it is not in the CodingStyle file. But mostly it is the convention that is followed. And in CodingStyle file if you see the "The rationale for using gotos is:" section, you will see in the example function the test is done like: if (!buffer). Anyways, frankly speaking I know commit message is bad but I could not think of anything else other than the one I wrote. Any ideas please...
regards sudip
| |