lkml.org 
[lkml]   [2015]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC v5 00/26] Re-use nvram module
From
Hi Finn,

On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
>> BTW, checkpatch reported a few newly-introduced whitespace errors in
>> patches 03, 05, 16, 24, and 25.
>
> I will check again, but I'm sure those are all deliberate. I examined all
> the "errors" and "warnings" before submitting.
>
> checkpatch doesn't really understand the difference between whitespace
> used for indentation of statements (according to scope) and whitespace
> used for alignment of terms or parameters (when line-wrapped). Any tool
> that fails to make that distinction can't be depended upon to correctly
> validate the elisp in Documentation/CodingStyle, for example.

Checkpatch complains because you don't replace a sequence of 8 spaces
by a TAB in continuation lines.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-08-17 10:41    [W:0.395 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site