lkml.org 
[lkml]   [2015]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] sched,fair: Remove > u32 weight handling for delta
Hi Peter,

On Mon, Jul 06, 2015 at 11:49:15PM +0530, Afzal Mohammed wrote:
> scaled down weight 'fact' would not be > u32 rather than unlikely as the
> weight being passed in __calc_delta() is either 'se->load.weight' or
> NICE_O_LOAD. 'se->load.weight' would be one of the values of
> prio_to_weight[] in the case of task, while in the case of task group it
> would be capped to MAX_SHARES. All those possible values can fit in u32.
> Hence remove the initial > u32 handling on 'fact'.
>
> Signed-off-by: Afzal Mohammed <afzal.mohd.ma@gmail.com>
> ---
>
> v2: expand change log on why weight can fit in u32, remove incorrect
> comments.
>
> kernel/sched/fair.c | 7 -------
> 1 file changed, 7 deletions(-)

bool __weak patch_adds_some_value(void)
{
return (~3 asm instruction less for calc_delta) && (less LOC);
}

if (patch_adds_some_value() && revised_message_okay())
please help $subject reach mainline;

Regards
Afzal


\
 
 \ /
  Last update: 2015-08-12 13:21    [W:0.097 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site