lkml.org 
[lkml]   [2015]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v8 1/3] sysfs: added sysfs_link_entry_to_kobj()
    On Wed, Aug 05, 2015 at 01:11:23PM -0700, Greg Kroah-Hartman wrote:
    > On Fri, Jul 03, 2015 at 05:27:18PM +0300, Jarkko Sakkinen wrote:
    > > Added a new function sysfs_link_group_to_kobj() that adds a symlink
    > > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns
    > > in order to provide a way to remove such symlinks.
    >
    > This text doesn't match the function name you exported :(

    D'oh.

    > >
    > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    > > ---
    > > fs/sysfs/group.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
    > > include/linux/sysfs.h | 10 ++++++++++
    > > 2 files changed, 54 insertions(+)
    > >
    > > diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
    > > index b400c04..0fb4b6e 100644
    > > --- a/fs/sysfs/group.c
    > > +++ b/fs/sysfs/group.c
    > > @@ -352,3 +352,47 @@ void sysfs_remove_link_from_group(struct kobject *kobj, const char *group_name,
    > > }
    > > }
    > > EXPORT_SYMBOL_GPL(sysfs_remove_link_from_group);
    > > +
    > > +/**
    > > + * __compat_sysfs_link_entry_to_kobj - add a symlink to a kobject pointing
    >
    > Why __compat?

    https://lkml.org/lkml/2015/7/2/455

    Although, should have been '__compat_only'.

    /Jarkko


    \
     
     \ /
      Last update: 2015-08-10 11:01    [W:2.710 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site