Messages in this thread Patch in this message | | | From | Andy Lutomirski <> | Subject | [RFC/PATCH v2 v2 4/6] x86/entry/32: Remove unnecessary asm check for returns to kernel mode | Date | Thu, 9 Jul 2015 19:17:32 -0700 |
| |
Unless I missed something, 44fbbb3dc687c ("x86: get rid of calling do_notify_resume() when returning to kernel mode") was unnecessarily paranoid. It split the exit path into resume_userspace and resume_kernel, after which it was no longer possible to get to work_notifysig when returning to kernel mode. The check for kernel mode in work_notifysig is superfluous. Remove it.
Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andy Lutomirski <luto@kernel.org> --- arch/x86/entry/entry_32.S | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index a36d5df6a749..66ff9c4055d7 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -491,10 +491,6 @@ work_notifysig: # deal with pending signals and #endif TRACE_IRQS_ON ENABLE_INTERRUPTS(CLBR_NONE) - movb PT_CS(%esp), %bl - andb $SEGMENT_RPL_MASK, %bl - cmpb $USER_RPL, %bl - jb resume_kernel xorl %edx, %edx call do_notify_resume jmp resume_userspace -- 2.4.3
| |