Messages in this thread | | | Date | Thu, 9 Jul 2015 10:39:58 +0200 | Subject | Re: kdbus: to merge or not to merge? | From | Geert Uytterhoeven <> |
| |
On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <pavel@ucw.cz> wrote: > Apparently, new tools are needed in the community, as normal review > comments did not stop drivers/android/binder.c merge. > > For example binder_transaction does not exactly look like a kernel > code, "TODO: fput" does not really invoke confidence, and ammount of > BUG_ON()s is quite amazing...
Amazingly, checkpatch (without --strict) only complains about long lines.
Seems like the test for "BUG" is (and always has been) commented out...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |