Messages in this thread | | | Date | Wed, 8 Jul 2015 10:24:30 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] uio: Destroy uio_idr on module exit |
| |
On Wed, Jul 08, 2015 at 05:24:46PM +0200, Johannes Thumshirn wrote: > Destroy uio_idr on module exit, reclaiming the allocated memory. > > This was detected by the following semantic patch (written by Luis Rodriguez > <mcgrof@suse.com>) > <SmPL> > @ defines_module_init @ > declarer name module_init, module_exit; > declarer name DEFINE_IDR; > identifier init; > @@ > > module_init(init); > > @ defines_module_exit @ > identifier exit; > @@ > > module_exit(exit); > > @ declares_idr depends on defines_module_init && defines_module_exit @ > identifier idr; > @@ > > DEFINE_IDR(idr); > > @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ > identifier declares_idr.idr, defines_module_exit.exit; > @@ > > exit(void) > { > ... > idr_destroy(&idr); > ... > } > > @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ > identifier declares_idr.idr, defines_module_exit.exit; > @@ > > exit(void) > { > ... > +idr_destroy(&idr); > } > > </SmPL> > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Nice work. Shouldn't we do the same thing for ida_destroy() as well? I see 4 USB drivers that need this same fix for that structure.
thanks,
greg k-h
| |