Messages in this thread | | | From | Alexander Shishkin <> | Subject | Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices | Date | Wed, 08 Jul 2015 15:49:03 +0300 |
| |
Chunyan Zhang <zhang.lyra@gmail.com> writes:
>> +int __init stp_configfs_init(void) >> +{ >> + int err; >> + >> + config_group_init(&stp_policy_subsys.su_group); >> + mutex_init(&stp_policy_subsys.su_mutex); >> + err = configfs_register_subsystem(&stp_policy_subsys); >> + >> + return err; > > One small suggestion, is it better like this: > return configfs_register_subsystem(&stp_policy_subsys); > As such, we don't need the local variable "err" any more.
You are right, err doesn't serve any purpose here.
Thanks, -- Alex
| |