lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices
Date
Chunyan Zhang <zhang.lyra@gmail.com> writes:

>> +int __init stp_configfs_init(void)
>> +{
>> + int err;
>> +
>> + config_group_init(&stp_policy_subsys.su_group);
>> + mutex_init(&stp_policy_subsys.su_mutex);
>> + err = configfs_register_subsystem(&stp_policy_subsys);
>> +
>> + return err;
>
> One small suggestion, is it better like this:
> return configfs_register_subsystem(&stp_policy_subsys);
> As such, we don't need the local variable "err" any more.

You are right, err doesn't serve any purpose here.

Thanks,
--
Alex


\
 
 \ /
  Last update: 2015-07-08 15:01    [W:0.174 / U:8.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site