lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks
On Tue, Jul 07, 2015 at 06:10:43PM +0800, Chunyan Zhang wrote:
> Add the function 'trace_event_stm_output_##call' for printing events
> trace log into STM blocks.
>
> This patch also adds a function call at where the events have been
> committed to ring buffer to export the trace event information to
> STM blocks.

So then you have two copies of the data, why that? Would a scheme were
data either goes to the STM or the regular buffer not make much more
sense?

> +++ b/include/trace/perf.h
> @@ -175,6 +175,7 @@ trace_event_raw_event_##call(void *__data, proto) \
> { assign; } \
> \
> trace_event_buffer_commit(&fbuffer); \
> + trace_event_stm_log(&fbuffer); \

This makes every trace event slower.

> }
> /*
> * The ftrace_test_probe is compiled out, it is only here as a build time check


\
 
 \ /
  Last update: 2015-07-08 14:41    [W:0.135 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site