lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/9] cpufreq: Introduce support for ST's cpufreq functionality
On 08-07-15, 11:59, Lee Jones wrote:
> No problem. So long as it's still on your radar.

So, for the first 7 patches:

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

but for the last two:
- I thought we agreed that you will have a look at opp-v2 bindings and
create your new bindings as an extension of those ? As we support
extending opp-v2 bindings per vendor basis.
- And I don't really think you need to create a device for your STM
driver, why not move your stm-cpufreq file to arch/arm/- and call it
from .init_late, from where you call init_cpufreq() today. Your
driver doesn't have anything related to cpufreq-core really and
isn't required to stay in drivers/cpufreq, unless you want it that
way.

I haven't reviewed the driver yet and waiting for an answer to opp-v2
question I asked above. opp-v2 is created because we didn't wanted
platforms to create new separate bindings for OPPs :)

--
viresh


\
 
 \ /
  Last update: 2015-07-08 13:41    [W:0.061 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site