lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 0/4] iosf_mbi: clean up
On Wed, 8 Jul 2015, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > There are few patches to clean up (with small fixes) iosf_mbi driver along with
> > extension it to cover Intel Tangier.
> >
> > Andy Shevchenko (4):
> > iosf_mbi: check result for all calls of debugfs API
> > iosf_mbi: pci_dev_put() is NULL-proof
> > iosf_mbi: group global variables
> > iosf_mbi: append Intel Tangier ID
> >
> > arch/x86/include/asm/iosf_mbi.h | 8 ++++----
> > arch/x86/kernel/iosf_mbi.c | 31 +++++++++++++++----------------
> > 2 files changed, 19 insertions(+), 20 deletions(-)
>
> Could you please also move it from arch/x86/kernel/ to
> arch/x86/platform/[intel-quark?] while at it?
>
> arch/x86/kernel/ is the wrong place for this driver.

Aside of that the patch prefixes should be:

x86/platform/iosf_mbi:

or something like that.

Thanks,

tglx


\
 
 \ /
  Last update: 2015-07-08 12:21    [W:0.107 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site